Add CORS middleware and update documentation #211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rragundez
changed the title
Collaborator
|
@LucasQR test this one when possible |
Contributor
Author
if it helps I have been using already |
Collaborator
|
@rragundez looks great! Can you please just update the readme (we changed the structure a lot), add example in the .env.example and maybe also in the docs? Then I can merge |
Collaborator
|
I'll make the requested changes and test the code a bit more so it can be merged |
Contributor
Author
|
I'll be adding a PR for environment variables of the backend and frontend host, this will make it easier for the user to specify the origins without hardcoding in the source code. In addition i also need these env variables for defining the redirect URLS when using oauth, and they are handy for other uses in an application backend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add CORS middleware by default as it is best practice. Then make it flexible in order for the user to follow advice in docs when in staging or production and instead of going into the source code, manipulate the CORS origins, methods and headers via the environment variables.
NOTE: I have not tested fully this change. I can do it tomorrow or if you can help validate, that would be great.